Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some default values for the PopIII test #613

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

psharda
Copy link
Contributor

@psharda psharda commented Apr 19, 2024

Description

Slightly lowering the jeans density refinement threshold and raising the density threshold for chemistry avoids a crash due to VODE in the background region.

Related issues

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@psharda psharda requested a review from BenWibking April 19, 2024 08:27
@psharda
Copy link
Contributor Author

psharda commented Apr 19, 2024

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@psharda
Copy link
Contributor Author

psharda commented Apr 19, 2024

This can be approved now @BenWibking

@BenWibking BenWibking added this pull request to the merge queue Apr 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 19, 2024
@BenWibking BenWibking added this pull request to the merge queue Apr 19, 2024
Merged via the queue into quokka-astro:development with commit cab810d Apr 19, 2024
19 checks passed
@psharda psharda deleted the p3minor branch April 19, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants