Build: Support Node.js export parity with CommonJS #709
Conversation
| QUnit.test( "QUnit exports", function( assert ) { | ||
| var qunit = require( "../dist/qunit" ); | ||
|
|
||
| assert.ok( qunit, "Required module QUnit truthy" ); |
There was a problem hiding this comment.
This might be discarded regarding the following test.
There was a problem hiding this comment.
I removed one of the following assertions but I intend to keep this one simple assertion.
|
@JamesMGreene could you update this? |
|
Updated. Added another commit to address a few of the PR feedback comments. I have no rebased it yet, just for the sake of seeing the changes to the 1st commit and the comment history. I'll happily rebase it whenever we think it's ready to be merged. |
|
Eh... the commits were small enough, so I went ahead and rebased against My 2nd commit (now just rebased into the primary commit) was just removing 2 assertions (and 1 test) related to the now-irrelevant |
|
Looks good to me. |
|
merged |
|
P.S. @jdalton Sorry, forgot to tag you on this earlier. |
Ref #521
More info: #521 (comment)
Basically, we want to ensure that
require('qunitjs').QUnitworks in all CommonJS environments, even if it is achieved byQUnit.QUnit = QUnit. Node.js was the only outlier at this point.Also added and updated a few related tests.