Where we recieve no exception in raises() use a relevant message. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional optional argument to pushFailure() which can be used to write a message corresponding to what occurred. In the raises assertion if actual is undefined it means no exception occurred; since we were expecting one in this case use the modified pushFailure() to notify the user.
| @@ -790,6 +792,10 @@ extend( QUnit, { | |||
| output += "<table><tr class='test-source'><th>Source: </th><td><pre>" + escapeInnerText( source ) + "</pre></td></tr></table>"; | |||
| } | |||
|
|
|||
| if ( actual ) { | |||
| output += "<table><tr class='test-actual'><th>Result: </th><td><pre>" + escapeInnerText( actual ) + "</pre></td></tr></table>"; | |||
There was a problem hiding this comment.
For consistency with other output, maybe put Result above Source.
|
Thanks for the suggestion - I reordered actual above source and also took a cue from QUnit.push() to avoid repeating the opening/closing table tags in the output. Regarding the message displayed, I'd originally chosen "No exception was raised." but am now in two minds myself about whether it should say raised or thrown. Do you have a preference? |
|
Its now |
|
I was very inclined to say "thrown" also - and with the method name change it all seems consistent. Just pushed a small revision which changes the output message to read "No exception was thrown." |
|
Thanks! Rebased into f4f91c8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in qunit if you write an assertion as follows:
raises(function() {
...
// raises no exception
});
the message you receive in qunit says your return value does not match null. I stumbled on this while writing unit tests for some code where I work and it caused a short head scratching moment until I looked in the qunit code.
Please let me know if you'd prefer me to open an issue and debate a solution there - since this is my first attempt at a contribution to qunit I'm happy to refactor / rework the solution as necessary.