Sorted object diff to improve failure output (fixes issue #206) #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s where properties were set in a different order.
|
Thanks! Rebased to cleanup whitespace (replacing spaces with tabs) and reordered some var declarations: 3c653d4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: http://jsfiddle.net/mhpZA/
After: http://jsfiddle.net/mhpZA/1/
(note that previously, the diff output depended on the object property definition/setting order, and incorrectly showed additions/deletions where property values were identical, and now it does not)
I considered adding new tests for this but as far as I could tell there were no tests for the diff output, only for jsDump output and, so I left it at this.