Fix unittest failures in Node14 under coverage mode #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1593.
The failing unittests for the ESM support lead to repairs in
src/cli/run.js. I was observing different errors than just the one we were sniffing for, so I added another check with as much granularity as possible. This passes in both coverage and non-coverage runs now.The other failing unittest was regarding source-maps; here we were simply getting different stack traces based on maps, and from what I could gather, the codecoverage mode was already doing mapping, and then
--enable-source-mapsdoes more, and seemed to be conflicting. I filtered this test under code coverage mode by inspecting theNYC_PROCESS_IDenv var. I wanted to useBUILD_TARGET=coverage, but that is being set in a different process from what ultimately runs this test.