Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix double begin when calling start in Node #1103

Merged
merged 1 commit into from
Feb 23, 2017
Merged

Core: Fix double begin when calling start in Node #1103

merged 1 commit into from
Feb 23, 2017

Conversation

trentmwillis
Copy link
Member

@trentmwillis trentmwillis commented Feb 20, 2017 •
edited
Loading

Fixes #1102.

Note: Unsure how we can test this since the issue manifests itself as done being triggered twice which our reporter exits after the first done call.

@trentmwillis trentmwillis mentioned this pull request Feb 20, 2017
Closed
@trentmwillis trentmwillis merged commit 03d8383 into qunitjs:master Feb 23, 2017
@trentmwillis trentmwillis mentioned this pull request Mar 11, 2017
Merged
@trentmwillis trentmwillis mentioned this pull request Mar 28, 2017
Closed
@trentmwillis trentmwillis deleted the double-begin branch March 2, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinumazure platinumazure platinumazure approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trentmwillis @platinumazure