Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Setup failed" doesn't have useful stack trace #210

Closed
wycats opened this issue Mar 6, 2012 · 1 comment
Closed

"Setup failed" doesn't have useful stack trace #210

wycats opened this issue Mar 6, 2012 · 1 comment

Comments

@wycats
Copy link

wycats commented Mar 6, 2012

When the setup fails, the stack trace provided is inside QUnit. Unlike #209, this should be easier to fix.
@jzaefferer
Copy link
Member

Fixed! For this I did a bigger refactor, actually improving the output of a lot more then just this case. See the commit and commit message for details.

rwaldron pushed a commit to rwaldron/qunit that referenced this issue Mar 13, 2012
@jzaefferer @rwaldron
Add QUnit.pushFailure to log error conditions like exceptions. Accept…
40aaa8c 
…s stacktrace as second argument, allowing extraction with catched exceptions (useful even in Safari). Remove old fail() function that would just log to console, not useful anymore as regular test output is much more useful by now. Move up QUnit.reset() call to just make that another failed assertion. Used to not make a test fail. Fixes qunitjs#210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wycats @jzaefferer