Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix start on Node when autostart is not set to true #1105

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

trentmwillis
Copy link
Member

When I submitted #1103, it turns out the test-on-node task never actually ran. The reason is that we don't set autostart to true. This fix will handle that case as well.

Copy link
Contributor

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the goal is to ensure QUnit.autostart is set whenever !config.pageLoaded (while invoking QUnit.load in non-browser contexts)?

@platinumazure
Copy link
Contributor

Oh, and is the issue fixed by this PR the reason why grunt doesn't actually run the node or browser tests? If so, I'd love to get this merged soon!

@trentmwillis
Copy link
Member Author

I assume the goal is to ensure QUnit.autostart is set whenever !config.pageLoaded (while invoking QUnit.load in non-browser contexts)?

Yes, this is because we can assume that someone calling start is expecting the tests to start ASAP.

is the issue fixed by this PR the reason why grunt doesn't actually run the node or browser tests?

Yep. And the Travis job shows them properly running now. If this looks good to you, we can merge.

Copy link
Contributor

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining! This looks good to me, I'll merge right away.

@platinumazure platinumazure merged commit c45038f into qunitjs:master Mar 11, 2017
@trentmwillis trentmwillis deleted the autostart-node branch March 2, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants