Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Remove "todo" from Assertion event data #119

Merged
merged 2 commits into from
Sep 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/Data.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,13 @@ class Assertion {
* @param {*} expected
* @param {String} message
* @param {String|undefined} stack
* @param {Boolean} todo
*/
constructor (passed, actual, expected, message, stack, todo) {
constructor (passed, actual, expected, message, stack) {
this.passed = passed;
this.actual = actual;
this.expected = expected;
this.message = message;
this.stack = stack;
this.todo = todo;
}
}

Expand Down
1 change: 0 additions & 1 deletion spec/cri-draft.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ The **Assertion** object contains information about a single <<assertion>>.
* `Mixed` **expected**: The expected value passed to the assertion, should be similar to `actual` for passed assertions.
* `string` **message**: Name of the actual value, or description of what the assertion validates.
* `string|undefined` **stack**: Optional stack trace. For a "passed" assertion, it is always `undefined`.
* `boolean` **todo**: Whether this assertion was part of a todo test.

It is allowed for additional non-standard properties to be added to am Assertion object, by the testing framework or a reporter.

Expand Down
2 changes: 1 addition & 1 deletion test/integration/adapters.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function normalizeTestEnd (test) {
test.runtime = 42;
}

// Only check the "passed" and any "todo" property.
// Only check the "passed" property.
// Throw away the rest of the actual assertion objects as being framework-specific.
if (test.assertions) {
test.assertions.forEach(assertion => {
Expand Down