Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TapReporter needs circular ref filtering on JSON.stringify #104

Closed
krisselden opened this issue Nov 17, 2017 · 4 comments · Fixed by #130
Closed

TapReporter needs circular ref filtering on JSON.stringify #104

krisselden opened this issue Nov 17, 2017 · 4 comments · Fixed by #130
Assignees
@Krinkle @zackthehuman
Labels
Category: npm Package good first issue Type: Problem
Milestone
Package 2.0

Comments

@krisselden
Copy link

No description provided.

@trentmwillis
Copy link
Member

Definitely a bug. It shouldn't be too hard to fix.

@Krinkle
Copy link
Member

Krinkle commented Sep 27, 2020

Similar issue fixed in Tape's TAP reporter:
tape-testing/tape#24

Mocha:
mochajs/mocha@365dcd2

node-tap:
tapjs/tapjs@73aaa92

@Krinkle Krinkle self-assigned this Jan 2, 2021
@Krinkle Krinkle added this to the Package 2.0 milestone Jan 24, 2021
@zackthehuman
Copy link
Contributor

I'd be happy to try and tackle this. I got bit by this 3 months ago and again by it today, resulting in a rather nasty unhandledRejection issue with QUnit.

@Krinkle
Copy link
Member

Krinkle commented Feb 14, 2021

@zackthehuman Go for it!

zackthehuman added a commit to zackthehuman/js-reporters that referenced this issue Feb 14, 2021
@zackthehuman
Reporter: handle objects with cycles
87593db 
Updating `TapReporter` with the ability to handle objects with circular
references. This is needed for proper stringification of actual and
expected values that contain cycles.

Fixes qunitjs#104
This was referenced Feb 14, 2021
Merged
Closed
zackthehuman added a commit to zackthehuman/js-reporters that referenced this issue Feb 20, 2021
@zackthehuman
Reporter: handle objects with cycles
3258391 
Updating `TapReporter` with the ability to handle objects with circular
references. This is needed for proper stringification of actual and
expected values that contain cycles.

Fixes qunitjs#104
zackthehuman added a commit to zackthehuman/js-reporters that referenced this issue Feb 21, 2021
@zackthehuman
Reporter: handle objects with cycles
1a009dd 
Updating `TapReporter` with the ability to handle objects with circular
references. This is needed for proper stringification of actual and
expected values that contain cycles.

Fixes qunitjs#104
zackthehuman added a commit to zackthehuman/js-reporters that referenced this issue Feb 21, 2021
@zackthehuman
Reporter: handle objects with cycles
8307cc4 
Updating `TapReporter` with the ability to handle objects with circular
references. This is needed for proper stringification of actual and
expected values that contain cycles.

Fixes qunitjs#104
Krinkle pushed a commit that referenced this issue Feb 21, 2021
@zackthehuman
Reporter: Handle objects with cycles
c38f467 
Updating TapReporter with the ability to handle objects with circular
references. This is needed for proper stringification of actual and
expected values that contain cycles.

Fixes #104.
Closes #130.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Krinkle Krinkle

@zackthehuman zackthehuman

Labels
Category: npm Package good first issue Type: Problem
Milestone
Package 2.0
Development

Successfully merging a pull request may close this issue.

Reporter: handle objects with cycles zackthehuman/js-reporters
4 participants
@krisselden @Krinkle @zackthehuman @trentmwillis