fix: Handle arrow function test with except-simple option in `requi…

…re-expect` rule
qunitjs · Aug 27, 2022 · 5b275f6 · 5b275f6
1 parent ef8f129
commit 5b275f6
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 4 deletions.
diff --git a/lib/rules/require-expect.js b/lib/rules/require-expect.js
@@ -128,14 +128,16 @@ module.exports = {
                 }
             },
 
-            "BlockStatement, ArrowFunctionExpression[body.type!='BlockStatement]": function () {
-                if (currentTest) {
+            "BlockStatement, ArrowFunctionExpression[body.type!='BlockStatement]": function (node) {
+                // Ignore any arrow function used by the test body itself i.e.: test('name', () => {})
+                if (currentTest && !currentTest.node.arguments.includes(node)) {
                     currentTest.blockDepth++;
                 }
             },
 
-            "BlockStatement, ArrowFunctionExpression[body.type!='BlockStatement]:exit": function () {
-                if (currentTest) {
+            "BlockStatement, ArrowFunctionExpression[body.type!='BlockStatement]:exit": function (node) {
+                // Ignore any arrow function used by the test body itself i.e.: test('name', () => {})
+                if (currentTest && !currentTest.node.arguments.includes(node)) {
                     currentTest.blockDepth--;
                 }
             }

diff --git a/tests/lib/rules/require-expect.js b/tests/lib/rules/require-expect.js
@@ -78,6 +78,11 @@ ruleTester.run("require-expect", rule, {
             code: "test('name', function(assert) { assert.expect(0); noParentObject() });",
             options: ["always"]
         },
+        {
+            // With arrow function
+            code: "test('name', assert => { assert.expect(0); noParentObject() });",
+            options: ["always"]
+        },
 
         // assert at top of test context is ok
         {
@@ -125,12 +130,24 @@ ruleTester.run("require-expect", rule, {
             options: ["except-simple"]
         },
 
+        // When the test is using an arrow function, make sure we still correctly-detect top-level expect.
+        {
+            code: "test('name', assert => { assert.expect(2); assert.ok(true); assert.ok(true); });",
+            options: ["except-simple"]
+        }
+
         // "never" - assert without expect is fine
         {
             code: "test('name', function(assert) { assert.ok(true) });",
             options: ["never"]
         },
 
+        // "never" - assert without expect is fine (with arrow function)
+        {
+            code: "test('name', assert => { assert.ok(true) });",
+            options: ["never"]
+        },
+
         // "never-except-zero" - assert without expect is fine
         {
             code: "test('name', function(assert) { assert.ok(true) });",
@@ -141,6 +158,12 @@ ruleTester.run("require-expect", rule, {
         {
             code: "test('name', function(assert) { assert.expect(0) });",
             options: ["never-except-zero"]
+        },
+
+        // "never-except-zero" - expect zero is fine (with arrow function)
+        {
+            code: "test('name', assert => { assert.expect(0) });",
+            options: ["never-except-zero"]
         }
     ],