util: Add basic network log seal support in timeline tools #5947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't as simple as I had hoped, but it does seem to work as it is. There's still a bit of fragility in
make_timeline
with this implementation, since it still relies on the seal name being present in game log form. We could change this to make "name from game log" optional in theassembleTimelineStrings()
function, but that would involve some complex conditions to allow for use of either the network seal or the game log seal.Alternatively, we could simply not care about game log seals at all, except to check "if there's a game log seal here, use the name it contains". Maybe something like this for the end of
assembleTimelineStrings()
?Ultimately it would be nice to have the seal names dumped to a resource file as we do with
ZoneId
andZoneName
, and then just look them up here, but I'm not feeling up to CSV stuff this weekend.