raidboss/oopsy: Aloalo variant left path #5941
Conversation
There was a problem hiding this comment.
cc @kshman who wrote most of these triggers
Sorry if I have changed to much and have been too opinionated here. I think having the timeline makes the need for some of these triggers go away, and I'm trying to be consistent with what other triggers have done in the past.
Also I still haven't seen this ability ever: #5893 (comment). Where does this happen? Edit: oh this is probably the right path, sorry
| if (data.quaArmamentsCount === 3) | ||
| return output.third!(); | ||
| return output.text!(); |
There was a problem hiding this comment.
I think the logic here was wrong. The third (and every one after) are all the donuts+axes combination.
| alertText: (_data, _matches, output) => output.text!(), | ||
| outputStrings: { | ||
| text: { | ||
| en: 'Go to safe NOW!', |
There was a problem hiding this comment.
This is very subjective, but in playing through I think the timeline covers the timing this trigger is warning about better than an alert text.
| infoText: (_data, _matches, output) => output.text!(), | ||
| outputStrings: { | ||
| text: { | ||
| en: 'Adds', |
There was a problem hiding this comment.
Usually "Adds" is when there are adds to kill. I think in this case, there's obvious ground markers to avoid, and so there's no need to tell players about adds.
| infoText: (_data, _matches, output) => output.text!(), | ||
| outputStrings: { | ||
| text: { | ||
| en: 'Adds', |
There was a problem hiding this comment.
Same thing here re: Adds.
| outputStrings: { | ||
| text: { | ||
| en: 'Avoid Chasing AOEs', |
There was a problem hiding this comment.
I think the Chasing AOE puddles are not worth calling out here. There's no headmarker on players (so it's not targeted on somebody directly) and it's on the timeline too.
| outputStrings: { | ||
| text: { | ||
| en: 'Bubbles float', |
There was a problem hiding this comment.
I changed this trigger into separate triggers with more specific depending on the path you're on.
|
Sorry, I made a lot of things wrong. I'm very inexperienced. Very thank you! 😭 |
Oh no, that's not what I was trying to say at all. I think the only thing that's even slightly wrong is just the Arcane Armaments 3 vs 4 count. The rest of it is just me having opinions about what's worth having a trigger about or what triggers are useful and isn't "right" or "wrong" in any way. Thanks for all your PRs, they've been really appreciated! |
No description provided.