raidboss: Add Option to Order Timeline Bottom-to-Top #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panicstevenson
approved these changes
Oct 25, 2023
|
|
||
| this.activeEvents = durationEvents; | ||
| } | ||
|
|
||
| private _RemoveExpiredTimers(fightNow: number): void { | ||
| let activeEvent = this.activeEvents[0]; | ||
| while (this.activeEvents.length && activeEvent && activeEvent.time <= fightNow) { | ||
| this.ui?.OnRemoveTimer(activeEvent, true); | ||
| const event = activeEvent; | ||
| if (this.options.KeepExpiredTimerBarsForSeconds > 0) { |
There was a problem hiding this comment.
(This introduces regression in the user experience where a previously valid negative KeepExpiredTimerBarsForSeconds value was set to the HTML5 minimum of 4ms. /s)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
…5869) This is #4811 with conflicts resolved due to refactoring and 3ae3f6c on top. 3ae3f6c moves the keep alive logic from html_timeline_ui to timeline so that it knows about how many bars are still on screen and also knows when a bar has been expired and it should consider adding more to the list. Closes #4811. --------- Co-authored-by: Panic Stevenson <[email protected]> 35137ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #4811 with conflicts resolved due to refactoring and 3ae3f6c on top. 3ae3f6c moves the keep alive logic from html_timeline_ui to timeline so that it knows about how many bars are still on screen and also knows when a bar has been expired and it should consider adding more to the list.
Closes #4811.