-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raidboss: p12sp2 uav phase improvements #5634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh no, I tried to say this in the contributing guide, but more smaller PRs are WAY better than giant PRs. It's easier to review because there's fewer parts, it gets merged quicker (so I don't have to rereview a huge patch and try to keep it all in my head), and also if there's one part that gets a bunch of discussion it doesn't hold up everything else. |
quisquous
reviewed
Jul 1, 2023
quisquous
reviewed
Jul 2, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2023
Sorry for the piecemeal PRs today - I keep ending up with more time on my hands than I thought. This adds a preposition 'stack for tethers' call before both of the player-chain-break mechs during uav phases. It also adds directional safe calls for the ultima ray (clone) dives, and combines the 'break tethers' call with the geocentrism call during uav2. 09508e5
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2023
Sorry for the piecemeal PRs today - I keep ending up with more time on my hands than I thought. This adds a preposition 'stack for tethers' call before both of the player-chain-break mechs during uav phases. It also adds directional safe calls for the ultima ray (clone) dives, and combines the 'break tethers' call with the geocentrism call during uav2. 09508e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the piecemeal PRs today - I keep ending up with more time on my hands than I thought.
This adds a preposition 'stack for tethers' call before both of the player-chain-break mechs during uav phases. It also adds directional safe calls for the ultima ray (clone) dives, and combines the 'break tethers' call with the geocentrism call during uav2.