raidboss: more P12S second phase #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshman
changed the title
|
This all seemed good to me, thank you! I think there's a few things I'll change, but I'll just merge this soon and fix them up myself (like the FIXME wording comments). |
quisquous
added a commit
that referenced
this pull request
Jun 29, 2023
* rewrote the Ultima Blow tethers to not depend on roles (since people can be dead and it can go weird) * used ids in more places * fixed headmarker id * updated English text * changed some alert severities * rewrote the classical 2 tracking which was wrong for the final player
quisquous
added a commit
that referenced
this pull request
Jun 29, 2023
This reverts commit 146e59d.
quisquous
added a commit
that referenced
this pull request
Jun 29, 2023
* rewrote the Ultima Blow tethers to not depend on roles (since people can be dead and it can go weird) * used ids in more places * fixed headmarker id * updated English text * changed some alert severities * rewrote the classical 2 tracking which was wrong for the final player
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
I made this PR for someone who can make more better triggers. If this PR is not enough for purpose, please discard this. Thank you. Added: * Palladian Grasp * Gaiaochos * The Classical Concepts * Caloric Theory f67933b
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
I made this PR for someone who can make more better triggers. If this PR is not enough for purpose, please discard this. Thank you. Added: * Palladian Grasp * Gaiaochos * The Classical Concepts * Caloric Theory f67933b
quisquous
added a commit
that referenced
this pull request
Jun 29, 2023
* rewrote the Ultima Blow tethers to not depend on roles (since people can be dead and it can go weird) * used ids in more places * fixed headmarker id * updated English text * changed some alert severities (also by making some things responses) * rewrote the classical 2 tracking which was wrong for the final player
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
* rewrote the Ultima Blow tethers to not depend on roles (since people can be dead and it can go weird) * used ids in more places * fixed headmarker id * updated English text * changed some alert severities (also by making some things responses) * rewrote the classical 2 tracking which was wrong for the final player cec3427
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
* rewrote the Ultima Blow tethers to not depend on roles (since people can be dead and it can go weird) * used ids in more places * fixed headmarker id * updated English text * changed some alert severities (also by making some things responses) * rewrote the classical 2 tracking which was wrong for the final player cec3427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this PR for someone who can make more better triggers.
If this PR is not enough for purpose, please discard this.
Thank you.
Added: