raidboss/oopsy: P11N Initial Package #5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quisquous
reviewed
May 30, 2023
ui/raidboss/data/06-ew/raid/p11n.txt
Outdated
| # Dark and Light Intro | ||
| 67.0 "--center--" sync / 1[56]:[^:]*:Themis:8235:/ window 30,30 | ||
| 73.1 "Dark and Light" sync / 1[56]:[^:]*:Themis:81C3:/ | ||
| 80.2 "Sigils of Discord" sync / 1[56]:[^:]*:Themis:81C4:/ window 76.2,15 |
There was a problem hiding this comment.
I'm not sure I understand this window, or the other ones below in Upheld Ruling or Styx x5?
There's also a lot of window 30,30 etc; is this really inconsistent, or just adding guide rails to make sure everything stays on track?
There was a problem hiding this comment.
Whoops, I knew I was going to miss something. I had to adjust the entire timeline four seconds later because the log I generated the base timeline from was early.
As for why there are so many safety syncs on an otherwise on-rails timeline, we've had situations before where pushes are discovered later. This is an attempt to get out ahead of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's done, a little later than everyone else. It's still missing the safespot calls for the illusory adds, since I haven't yet been able to figure out what's going on with those. Overall I'm not terribly happy with the textual choices I made here, but the nature of the mechanics here requires a little more than we normally might want.