raidboss: TOP add config option + rotation to omega dodge #5367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Legends0 if you wanted to test this out too |
Because the rotation direction depends on which side you have dodged to, it's impossible to write this PR without having the user pick which dodge they are doing. This promotes the dodge direction to a new option (defaulting to far, since that seems to be the PF approach) and adds in the rotation direction as well. Because there's an option, there's no longer any combo output strings for staff sword, and the correct one is picked.
quisquous
force-pushed
the
top_omega_rotation
branch
from
2e1bf8b to
43e67dd
Compare
I'll try this out next time my group runs (today or tomorrow). |
|
I had it call left then far E, but that was actually right. Using far dodge. |
|
After resetting my config, it seems to have resolve itself as I haven't been able to replicate the issue. |
quisquous
added a commit
that referenced
this pull request
Apr 28, 2023
|
This works well since the 5372 fix. Haven't had an issue with it. |
|
Ok, I think I'll land this and do a release. Thanks for all the testing. |
github-actions bot
pushed a commit
that referenced
this pull request
May 3, 2023
…odge (#5367) Because the rotation direction depends on which side you have dodged to, it's impossible to write this PR without having the user pick which dodge they are doing. This promotes the dodge direction to a new option (defaulting to far, since that seems to be the PF approach) and adds in the rotation direction as well. Because there's an option, there's no longer any combo output strings for staff sword, and the correct one is picked. 331e400
github-actions bot
pushed a commit
that referenced
this pull request
May 3, 2023
…odge (#5367) Because the rotation direction depends on which side you have dodged to, it's impossible to write this PR without having the user pick which dodge they are doing. This promotes the dodge direction to a new option (defaulting to far, since that seems to be the PF approach) and adds in the rotation direction as well. Because there's an option, there's no longer any combo output strings for staff sword, and the correct one is picked. 331e400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the rotation direction depends on which side you have dodged to, it's impossible to write this PR without having the user pick which dodge they are doing.
This promotes the dodge direction to a new option (defaulting to far, since that seems to be the PF approach) and adds in the rotation direction as well.
Because there's an option, there's no longer any combo output strings for staff sword, and the correct one is picked.