O5N Timeline #43
Merged
O5N Timeline #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable! Can you add this to o5n.js in the same way that o5s.js references o6s.txt as a timeline? If you've tested this yourself and it looks reasonable, I'm happy to merge it after that. |
|
Ah, I knew I forgot something. Yeah, I tested it and recorded it a few times to make sure it was fine. I never made it to the loop while I had the timeline up, but prior logs I have along with testing long-encounter o5n fflogs seems to prove that loop out to like 11 minutes. |
SiliconExarch
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jan 15, 2024
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jan 15, 2024
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an O5N timeline since it's nice to have in general, but also it'll be way easier to test #33 without getting a static together.