Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O5S Timeline syncs #39

Merged
merged 3 commits into from
Feb 7, 2018
Merged

O5S Timeline syncs #39

merged 3 commits into from
Feb 7, 2018

Conversation

xephero
Copy link
Contributor

@xephero xephero commented Feb 5, 2018

More complete version of O5S, still untested until tomorrow's reset. From #37

@quisquous
Copy link
Owner

I'll give this a run tomorrow night too and then merge after that if it looks good.

Thanks a bunch! Appreciate the separate pull requests too. It makes it a lot easier to work with.

@xephero
Copy link
Contributor Author

xephero commented Feb 7, 2018

Just tested it, and it reset after adds. The console has OnSync messages up to 203 (the Diabolic Wind in add phase), and after that no syncs happened. I'm not sure if it should print a message if the jump 0 errantly came up at any point. My log doesn't have any "Removing combatant Phantom Train" until the end though.

@ghost
Copy link

ghost commented Feb 7, 2018

Same just happened to me, the timeline halted during midphase when ghosts were out.

@xephero
Copy link
Contributor Author

xephero commented Feb 7, 2018

Added gigantic sync windows for the abilities that the boss only uses once in the whole fight. If it does end up stopping for some reason, it should resync once it sees those.

@quisquous quisquous merged commit 8f55c7c into quisquous:master Feb 7, 2018
@quisquous
Copy link
Owner

quisquous commented Feb 7, 2018

I think there's still some bugs to fix here (in cactbot, I mean), but this is an improvement over what was there before.

EDIT: Thanks for all the timelines! Your work is super appreciated.

@quisquous quisquous mentioned this pull request Feb 7, 2018
@xephero
Copy link
Contributor Author

xephero commented Feb 7, 2018

I've been making these for myself and my statics since Gordias, I'm just happy to have a channel to get them out there more effectively. Thanks for your work!

@xephero xephero deleted the o5s-timeline branch February 25, 2018 04:58
SiliconExarch pushed a commit to SiliconExarch/cactbot that referenced this pull request Jan 6, 2024
fixes a URL typo introduced in #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants