Update royal_city_of_rabanastre.js #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated triggers for mask.
|
Ohmygosh, thanks! I had thought originally that the mask ability only occurred after the divine commandment debuff wore off, but double checking the logs that's not true at all. As a side question, have you had any lag problems with triggers in Rabanastre with cactbot, especially on Hashmal or Argath? |
|
No issues here with lag during Rabanastre, I do have TTS off so not sure if that would make a difference. |
SiliconExarch
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jan 5, 2024
Closes quisquous#18. (ref discussion in quisquous#5943). Instead of ignoring all abilities used by combatants with an empty name field, `make_timeilne` will now include entries in the timeline and the timeline ability table if the empty-name combatant uses a named ability.
SiliconExarch
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jan 6, 2024
Closes quisquous#18. (ref discussion in quisquous#5943). Instead of ignoring all abilities used by combatants with an empty name field, `make_timeilne` will now include entries in the timeline and the timeline ability table if the empty-name combatant uses a named ability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated triggers for mask.