Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oopsy]: Divine Veil abilityID vs effectID mismatch #5418

Closed
xiashtra opened this issue May 25, 2023 · 1 comment · Fixed by #5419
Closed

[oopsy]: Divine Veil abilityID vs effectID mismatch #5418

xiashtra opened this issue May 25, 2023 · 1 comment · Fixed by #5419
Labels
bug

Comments

@xiashtra
Copy link
Contributor

#5416 introduced a bug with the oopsyraidsy Divine Veil missed buff check: the check uses the abilityID in an effectID field buff_map.ts#LL38C1-L47C5. 0xdd4 is the abilityID for Divine Veil which directly heals and applies a shield with the statusEffectID 0x552.
@xiashtra xiashtra added the bug label May 25, 2023
@quisquous
Copy link
Owner

Oops, thank you

quisquous added a commit that referenced this issue May 25, 2023
@quisquous
oopsy: update veil id again
90d9135 
Ability id added in #5416 but should have been effect id.

Fixes #5418.
@quisquous quisquous mentioned this issue May 25, 2023
Merged
quisquous added a commit that referenced this issue May 25, 2023
@quisquous
oopsy: update veil id again (#5419)
85e054e 
Ability id added in #5416 but should have been effect id.

Fixes #5418.
github-actions bot pushed a commit that referenced this issue May 25, 2023
gh-pages build: oopsy: update veil id again (#5419)
e518705 
Ability id added in #5416 but should have been effect id.

Fixes #5418. 85e054e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

oopsy: update veil id again quisquous/cactbot
2 participants
@quisquous @xiashtra