Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled trigger require regex or netRegex #4965

Closed
trim21 opened this issue Oct 23, 2022 · 2 comments · Fixed by #5403
Closed

disabled trigger require regex or netRegex #4965

trim21 opened this issue Oct 23, 2022 · 2 comments · Fixed by #5403
Labels

Comments

@trim21
Copy link
Contributor

trim21 commented Oct 23, 2022

Description

a disabled trigger { id: "DSR Dragon's Rage", disabled: true } not fail at

if (!isRegexTrigger(trigger) && !isNetRegexTrigger(trigger)) {
console.error(`Trigger ${id}: has no regex property specified`);
continue;
}

previous it you can disable a builtin trigger with this, but it's broken now.

@trim21 trim21 added the bug label Oct 23, 2022
@Souma-Sumire
Copy link
Contributor

Yeah, it makes it very cumbersome to disable triggers.

@trim21
Copy link
Contributor Author

trim21 commented Dec 31, 2022

this will be fixed by #5047 but I don't have time or energy to fix it in these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants