GNB and return data.role == 'tank' not working #453
Comments
|
upon further testing, using the test.HTML, i'm reported as being on job 60 GNB when on Dancer and job 80 DNC when on GNB |
|
From what i noticed in FFXIVProcess.cs line 121 and 122 the job IDs for Dnc and Gnb are swapped, Gnb should be 37 and Dnc should be 38, not the other way around. |
|
WHOOPS. Thanks for this catch. I swear I looked at the tables from Saint Coinach to write this, but I should have tested this properly. Sorry! There's not really a way for me to fix this until I get back this next weekend, but I'll put out a new release then. |
Closed
SiliconExarch
pushed a commit
to SiliconExarch/cactbot
that referenced
this issue
Oct 31, 2024
This series includes several strategy options for the m4s fight that fit the standard NA PF strategies. - **raidboss: add support for DN strategy for Ion Cluster in m4s** - **raidboss: add support for DN strategy during Witch Hunt in m4s** - **raidboss: add uptime sunrise sabaath callouts in m4s** These are based off the shabin pastebin and hector guide, with the uptime waymarks strategy for sunrise sabaath. I made all of these configuration options, so that existing default callouts which do not use a specific strategy are not affected. I tried to put good brief explanations, and used the standard strat names I see going around. I've tested variations of this code in my runs, though it did not use a strategy option at the time. Thus, this exact code is not yet battle tested outside of the simulator. --------- Signed-off-by: Jacob Keller <[email protected]>
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this issue
Oct 31, 2024
…us#453) This series includes several strategy options for the m4s fight that fit the standard NA PF strategies. - **raidboss: add support for DN strategy for Ion Cluster in m4s** - **raidboss: add support for DN strategy during Witch Hunt in m4s** - **raidboss: add uptime sunrise sabaath callouts in m4s** These are based off the shabin pastebin and hector guide, with the uptime waymarks strategy for sunrise sabaath. I made all of these configuration options, so that existing default callouts which do not use a specific strategy are not affected. I tried to put good brief explanations, and used the standard strat names I see going around. I've tested variations of this code in my runs, though it did not use a strategy option at the time. Thus, this exact code is not yet battle tested outside of the simulator. --------- Signed-off-by: Jacob Keller <[email protected]> 2d8a434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hello, i was running inno EX and the tank specific triggers do not seem to be triggering when i was on GNB. log is attached
Network_20190709.log
The text was updated successfully, but these errors were encountered: