Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS Changes and the character [#] in Triggers #178

Closed
Hoshiyuu opened this issue Jun 30, 2018 · 2 comments
Closed

TTS Changes and the character [#] in Triggers #178

Hoshiyuu opened this issue Jun 30, 2018 · 2 comments

Comments

@Hoshiyuu
Copy link

Hoshiyuu commented Jun 30, 2018

With the recent TTS changes in most triggers, setting TTS readouts on popup texts now cause some callouts such as Byakko stack, Nael's Cleanse to read [#] as [Sharp] causing weird and long callouts.
(e.g. Nael's "Cleanse Sharp 1 : Firstname Lastname")

I don't see a way to easily override these triggers since they are quite non-standard for Coils, is there an example to change these without needing to reapplying the changes to the non-user trigger.js file everytime an update overwrites the old files?;

and is there a change planned for the master files on github?

@quisquous
Copy link
Owner

Oh, hmm. That does seem awkward. Thanks for mentioning this. I'll do a search and replace on tts strings to remove # before playing them out.

What do you mean by a change planned for the master files?

@Hoshiyuu
Copy link
Author

Hoshiyuu commented Jun 30, 2018

Ah, what I meant was if you were going to roll the changes into the files, or introduce a way for user config customization, but with the method used in b2d4ac9 nothing else need to be changed, thanks!

SiliconExarch pushed a commit to SiliconExarch/cactbot that referenced this issue Jun 30, 2024
**NOTE: File updates contain 7.0 spoilers.  Review at your own peril.**

Old XIVAPI was updated before the beta, which is pending updates to
EXDSchema, so this PR was generated based on the old api.

There were schema & data changes that required code fixes beyond just
the data refresh, so I think it makes sense to merge this first, and
then fix and re-test the beta API refactor before merging quisquous#171.
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Jun 30, 2024
**NOTE: File updates contain 7.0 spoilers.  Review at your own peril.**

Old XIVAPI was updated before the beta, which is pending updates to
EXDSchema, so this PR was generated based on the old api.

There were schema & data changes that required code fixes beyond just
the data refresh, so I think it makes sense to merge this first, and
then fix and re-test the beta API refactor before merging quisquous#171. e92f477
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this issue Jun 30, 2024
**NOTE: File updates contain 7.0 spoilers.  Review at your own peril.**

Old XIVAPI was updated before the beta, which is pending updates to
EXDSchema, so this PR was generated based on the old api.

There were schema & data changes that required code fixes beyond just
the data refresh, so I think it makes sense to merge this first, and
then fix and re-test the beta API refactor before merging quisquous#171. e92f477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants