-
Notifications
You must be signed in to change notification settings - Fork 384
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
triggers build: raidboss: update ARR/HW/SB timelines to use InCombat …
…lines (#5555) Intending this PR to finish out the remaining work from #5440 . Marked as draft pending discussion below. Right now, it includes timeline updates for everything in 02-arr, using 0x104 lines to start the timeline vs. engage or zone-seal messages where it makes sense. There's a few of the coils fights where there are various pre-boss add encounters, so using 0x104 lines -- at least by themselves -- will produce inaccurate results. I've added comments where needed. Before I start tackling later expansions, this issue of using 0x104 lines in encounters with pre-boss adds will become a more common issue, particularly in dungeon and alliance content (some of the alex raids as well, and doubtless there are others). There's probably at least two options, maybe more, but wanted to discuss approach before I dig in further: 1. Continue to use engage or zone-seal messages (as-is) where 0x104 lines have the potential to start the timeline early. (Easiest) 2. Use a combination of engage/zone-seal messages for the initial timeline encounter, and use 0x104 lines with large windows for later encounters. While this might be viable in some current content where spacing between bosses and mobs is at least somewhat predictable, it becomes inaccurate as soon as the content can be unsync'd (if not sooner). It would also require a pretty intensive re-look at older fight content to try to figure out exactly how to space out the timeline entries between combat and what appropriate look-back windows for 0x104 lines would be. TLDR: leaning toward option 1 since I *think* this is nice-to-have work and not break-fix? a44b96f
- Loading branch information
github-actions
committed
Jun 19, 2023
1 parent
f449263
commit be474a2
Showing
123 changed files
with
140 additions
and
598 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.