Skip to content

Commit

Permalink
jobs: 6.4 update (#5406)
Browse files Browse the repository at this point in the history
Atonement no longer interrupt combo.
  • Loading branch information
Echoring authored May 23, 2023
1 parent bb262c1 commit 0a1589a
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
8 changes: 4 additions & 4 deletions ui/jobs/combo_tracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { EventEmitter } from 'eventemitter3';
import {
kComboActions,
kComboBreakers,
kComboBreakers610,
kComboBreakers620,
kComboBreakers630,
kComboDelay,
} from './constants';
import { FfxivVersion } from './jobs';
Expand Down Expand Up @@ -115,10 +115,10 @@ export class ComboTracker extends EventEmitter<{ combo: ComboCallback }> {

static setup(ffxivVersion: FfxivVersion, player: Player): ComboTracker {
let breakers;
if (ffxivVersion < 620)
breakers = kComboBreakers610;
else if (ffxivVersion < 630)
if (ffxivVersion < 630)
breakers = kComboBreakers620;
else if (ffxivVersion < 640)
breakers = kComboBreakers630;
else
breakers = kComboBreakers;

Expand Down
12 changes: 6 additions & 6 deletions ui/jobs/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,6 @@ export const kComboBreakers = [
kAbility.TotalEclipse,
kAbility.Prominence,
kAbility.ShieldBash,
kAbility.Atonement,
// WAR
kAbility.HeavySwing,
kAbility.Maim,
Expand Down Expand Up @@ -539,14 +538,15 @@ export const kComboBreakers = [
kAbility.Bladeshower,
];

export const kComboBreakers620 = [
export const kComboBreakers630 = [
...kComboBreakers,
kAbility.GoringBlade,
kAbility.Confiteor,
kAbility.Atonement,
];

export const kComboBreakers610 = [
...kComboBreakers,
export const kComboBreakers620 = [
...kComboBreakers630,
kAbility.GoringBlade,
kAbility.Confiteor,
];

// [level][Sub][Div]
Expand Down
8 changes: 4 additions & 4 deletions ui/jobs/jobs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ UserConfig.getUserConfigLocation('jobs', defaultOptions, () => {
// (Battle system changes will be merged in major update for CN/KO)
// (e.g. intl 6.38 job changes are merged in cn patch 6.3)
const ffxivlanguageToVersion: Record<Lang, FfxivVersion> = {
'en': 638,
'de': 638,
'fr': 638,
'ja': 638,
'en': 640,
'de': 640,
'fr': 640,
'ja': 640,
'cn': 630,
'ko': 625,
};
Expand Down

0 comments on commit 0a1589a

Please sign in to comment.