Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed -s. Invalid option for sha256sum #73

Closed
wants to merge 1 commit into from

Conversation

snachiap
Copy link

Hi,

While installing the plugin to centos, checksum validation fails with the below error

Screenshot 2020-10-15 at 14 22 50

The install binary sh file was updated to fix the issue.

I don't have a go environment setup, so unable to test the complete installation, but still tested the checksum validation part which was successful in Centos.

Thanks and incase the update the not correct, please help to fix the installation issue

@quintush
Copy link
Owner

Hello @snachiap ,

Thanks for the update.
I will verify if the options also works for other linux versions.

Creating a good installation for all distributions is maybe one of the hardest parts to accomplish.

Greetings,
@quintush

@snachiap
Copy link
Author

Thank you very much for the prompt response.

@quintush quintush linked an issue Nov 16, 2020 that may be closed by this pull request
@quintush
Copy link
Owner

It has been a while, but finally managed to verify several scenarios.

Only removing the -s option does fix the error, but does not fix the goal to be achieved.
The -s options makes sure that the exitcode is different when a invalid sha checksum is calculated.

I have created a fix, which still resolves your issue on CentOS and manage to keep the goal on validating the sha checksum.

@quintush quintush closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install fails with sha256sum
2 participants