Factor out IncomingToken
#2094
Merged
Factor out IncomingToken
#2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretchenfrage
commented
Dec 16, 2024
gretchenfrage
commented
Dec 16, 2024
Ralith
approved these changes
Dec 16, 2024
gretchenfrage
force-pushed
the
incoming-token
branch
from
494faa0 to
4ff986e
Compare
Factors out the retry_src_cid and orig_dst_cid fields of Incoming into a new token::IncomingToken struct.
Moves more logic from Endpoint::handle_first_packet to the proto::token module. Due to improved decoupling between modules, Token::from_bytes and ValidationError can now be made private.
gretchenfrage
force-pushed
the
incoming-token
branch
from
4ff986e to
9bf690e
Compare
|
CI fail is due to flake. |
13 tasks
djc
approved these changes
Dec 20, 2024
Merged
This was referenced Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved decoupling between modules, makes code flow easier to understand IMO, and sets us up to have an easier time adding more internal variants to
RetryToken, for NEW_TOKEN stuff.