Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust terminology regarding tokens #2086

Merged
merged 1 commit into from
Dec 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions quinn-proto/src/config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ pub struct ServerConfig {
/// Used to generate one-time AEAD keys to protect handshake tokens
pub(crate) token_key: Arc<dyn HandshakeTokenKey>,

/// Duration after a stateless retry token was issued for which it's considered valid
/// Duration after a retry token was issued for which it's considered valid
pub(crate) retry_token_lifetime: Duration,

/// Whether to allow clients to migrate to new addresses
Expand Down Expand Up @@ -254,7 +254,7 @@ impl ServerConfig {
self
}

/// Duration after a stateless retry token was issued for which it's considered valid
/// Duration after a retry token was issued for which it's considered valid
///
/// Defaults to 15 seconds.
pub fn retry_token_lifetime(&mut self, value: Duration) -> &mut Self {
Expand Down
3 changes: 1 addition & 2 deletions quinn-proto/src/endpoint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1307,8 +1307,7 @@ pub struct AcceptError {
pub response: Option<Transmit>,
}

/// Error for attempting to retry an [`Incoming`] which already bears an address validation token
/// from a previous retry
/// Error for attempting to retry an [`Incoming`] which already bears a token from a previous retry
#[derive(Debug, Error)]
#[error("retry() with validated Incoming")]
pub struct RetryError(Incoming);
Expand Down
3 changes: 1 addition & 2 deletions quinn/src/incoming.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ struct State {
endpoint: EndpointRef,
}

/// Error for attempting to retry an [`Incoming`] which already bears an address validation token
/// from a previous retry
/// Error for attempting to retry an [`Incoming`] which already bears a token from a previous retry
#[derive(Debug, Error)]
#[error("retry() with validated Incoming")]
pub struct RetryError(Incoming);
Expand Down
Loading