Add support for NetBSD, fix OpenBSD #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
commented
May 28, 2024
NetBSD does not support DONTFRAG or ECN on IPv4, but does for IPv6. It has recvmmsg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for NetBSD. As mentioned in the commit, it does not support DONTFRAG or ECN for IPv4, but does for IPv6. It has recvmmsg so I implemented that recv branch.
Also included is a fix for OpenBSD which also does not have IP_DONTFRAG for IPv4. Not sure how that slipped into #1863 / 98d8513.
I have tested this on all of OpenBSD, NetBSD and FreeBSD and all pass the test suite now.