EXTRACT-KRAUS-OPS: CL-QUIL::MAKE-ROW-MAJOR-MATRIX -> MAGICL:FROM-LIST #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleby
changed the title
The function CL-QUIL::MAKE-ROW-MAJOR-MATRIX was removed in quil-lang/quilc#574. Switch to using MAGIC:FROM-LIST, instead.
appleby
force-pushed
the
make-row-major-matrix->from-list
branch
from
4418b3a to
d08dc8f
Compare
notmgsk
approved these changes
Mar 2, 2020
colescott
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Just as a note magicl supports setting the magicl::*default-tensor-type* which we could set in quilc to be (complex double-float) to avoid having to specify the type everywhere. This isn't needed for this PR but could be added in the future to clean up matrix construction calls
Do it 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
CL-QUIL::MAKE-ROW-MAJOR-MATRIXwas removed in quil-lang/quilc#574.Switch to using
MAGIC:FROM-LIST, instead.