Use cl-quil's tools for safe resolution of included files #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleby
reviewed
Dec 18, 2019
examples/qaoa.lisp
Outdated
Comment on lines
70
to
73
| (let ((val (loop :for (from to) :in graph | ||
| :sum (logxor (ldb (byte 1 from) cut) | ||
| (ldb (byte 1 to) cut))))) | ||
| val)) |
Ah. Looking at test failures, it would appear so. |
jmbr
approved these changes
Dec 18, 2019
examples/qaoa.lisp
Outdated
| (loop :for (from to) :in graph | ||
| :sum (logxor (ldb (byte 1 from) cut) | ||
| (ldb (byte 1 to) cut)))) | ||
| (let ((val (loop :for (from to) :in graph |
There was a problem hiding this comment.
I don't see the rationale for wrapping the accumulated value of the loop in a let form only to return it immediately.
There was a problem hiding this comment.
I should've paid more attention to what I was committing.
Dang. Yes. |
stylewarning
approved these changes
Dec 18, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for this late PR. This removes some code duplication by using directly cl-quil's functions for safe resolution of include files.