Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansatz search #670

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Ansatz search #670

merged 3 commits into from
Sep 3, 2020

Conversation

stylewarning
Copy link
Member 

add a new matrix->ansatz function

This commit adds a new function MATRIX->ANSATZ useful for finding
matrices in a given form. It just boils down to a Nelder-Mead which is
particularly effective in many cases. This function can be used to
build compilers for relatively exotic gate sets, provided you've
discovered a function which can represent them.

@stylewarning stylewarning requested a review from a team as a code owner August 7, 2020 02:34
@stylewarning
Copy link
Member Author

whoops, didn't mean to include the other stuff

ecpeterson
ecpeterson previously approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@ecpeterson ecpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ Perhaps ~ one should open a tracking issue to use this utility in the template searching code in approx.lisp .

src/compilers/ansatz-search.lisp Outdated Show resolved Hide resolved
braised-babbage
braised-babbage reviewed Aug 10, 2020
View reviewed changes
src/compilers/ansatz-search.lisp Outdated Show resolved Hide resolved
src/compilers/ansatz-search.lisp Outdated Show resolved Hide resolved
src/compilers/ansatz-search.lisp Show resolved Hide resolved
@stylewarning
Copy link
Member Author

I’ll address these comments.

@stylewarning
add a new SOLVE-FOR-ANSATZ-INPUTS function
1ea60f9 
This commit adds a new function SOLVE-FOR-ANSATZ-INPUTS useful for
finding matrices in a given form. It just boils down to a Nelder-Mead
which is particularly effective in many cases. This function can be
used to build compilers for relatively exotic gate sets, provided
you've discovered a function which can represent them.
@stylewarning
Copy link
Member Author

@kilimanjaro I can't add you to re-review with the G U I, but maybe you'd like to do a second-over again.

braised-babbage
braised-babbage previously approved these changes Aug 26, 2020
View reviewed changes
src/compilers/ansatz-search.lisp Outdated Show resolved Hide resolved
src/compilers/ansatz-search.lisp Outdated Show resolved Hide resolved
@stylewarning @braised-babbage
fix spelling error
72db0a2 
Co-authored-by: Erik Davis <[email protected]>
@stylewarning @braised-babbage
simplify LET* to LET
a8b5f47 
Co-authored-by: Erik Davis <[email protected]>
@stylewarning
Copy link
Member Author

ping @notmgsk

@notmgsk notmgsk merged commit 8e28da9 into quil-lang:master Sep 3, 2020
@stylewarning stylewarning deleted the ansatz-search branch September 22, 2020 16:08
@notmgsk notmgsk mentioned this pull request Dec 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmgsk notmgsk notmgsk approved these changes

@braised-babbage braised-babbage braised-babbage left review comments

@ecpeterson ecpeterson Awaiting requested review from ecpeterson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stylewarning @braised-babbage @notmgsk @ecpeterson