ASN1_item_verify_ctx(): Return -1 on fatal errors

Fixes openssl#24575 Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#24576) (cherry picked from commit 8d380f8)
quictls · Jun 21, 2024 · ae1e12e · ae1e12e
1 parent ba389a5
commit ae1e12e
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/crypto/asn1/a_verify.c b/crypto/asn1/a_verify.c
@@ -203,10 +203,12 @@ int ASN1_item_verify_ctx(const ASN1_ITEM *it, const X509_ALGOR *alg,
     inl = ASN1_item_i2d(data, &buf_in, it);
     if (inl <= 0) {
         ERR_raise(ERR_LIB_ASN1, ERR_R_INTERNAL_ERROR);
+        ret = -1;
         goto err;
     }
     if (buf_in == NULL) {
         ERR_raise(ERR_LIB_ASN1, ERR_R_MALLOC_FAILURE);
+        ret = -1;
         goto err;
     }
     inll = inl;