Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in bitbackerx8 #11

Closed
trinity-1686a opened this issue Jun 25, 2019 · 1 comment · Fixed by #12
Closed

error in bitbackerx8 #11

trinity-1686a opened this issue Jun 25, 2019 · 1 comment · Fixed by #12

Comments

@trinity-1686a
Copy link
Contributor

There seems to be a copy-past error here, the index should be different from one another https://github.com/tantivy-search/bitpacking/blob/8cc0a1700e690de97b0bb4e0fb205024c0deaf3c/src/bitpacker8x.rs#L35-L36

@trinity-1686a
Copy link
Contributor Author

I've re-implemented it on the playground with some test vectors, the correct indices are 0 and 4.

I have to point out that variable names are misleading : _mm256_srli_si256 operate on 2 128b lanes, so that a,b,c,d and e,f,g,h can't get mixed, a__b__ca_db_ce_df_ge_hf should hence be a__b__ca_db_e__f__ge_hf (same goes for ___a__b__ca_db_ce_df_ge).

fulmicoton added a commit that referenced this issue Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant