feat(testing): New testing feature to enable running both a acceptor and initiator in the same process. #684
+496
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcross-ctoken
changed the title
kcross-ctoken
changed the title
… to back test in process
|
@ackleymi ... thoughts ? |
|
@ekovacs ? |
|
This has backwards compatibility, correct? Quite a lot of changes in here, but it certainly has a lot of benefits |
yup it does ... the functions in file provide the backwards compatibility also the existing "integration" tests should give some confidence in this too. |
|
@ackleymi ... can we get this merged sometime soon so I don't need to keep rebasing my fork ? |
|
@ackleymi, @michaelwilner .... is there a reason not to merge this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ablity to have a registry per instance of initiator or acceptor and not have session conflicts.
The main purpose of this is to allow in process testing of both initiator and Acceptor.
There is an example test service_test which does the whole setup and routing between initiator and acceptor in the same process.
This would also allow the "integration" or service tests to run against eachother without the need for a deployed service or a docker image. Using this technique will require less resources for running tests and they will run a lot faster.