Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Predefined Tags sync business logic to MigrationService #90

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Dec 4, 2021

This is to fix #89 by leveraging the fact that the MigrationService already is checking if Evolutions have been completed and making decisions. So we move some of the logic over to it.

I move the FeatureToggle check into the MigrationService, though not sure if that was the right way to go...

Now SMUI will start with an empty Database, run the Evolutions, and then when you restart, sync any predefined tags.

epugh pushed a commit to querqy/chorus that referenced this pull request Dec 4, 2021
@epugh
Copy link
Contributor Author

epugh commented Dec 4, 2021

There was some discussion on Stack overflow about lazy loading things in Play frameworks, so this issue might go away if we are on a newer Play framework.

@pbartusch
Copy link
Collaborator

Hi @epugh , thanks for the PR and for finding this bug.
I moved the whole routine for synch'ing the predefinedTags to the migrationService and removed it from the repository. It's different in nature, as it is nothing being used during the end user runtime of SMUI. It should not have been in the repository, in the first place.

@pbartusch pbartusch merged commit 5fdcffa into querqy:master Dec 17, 2021
@epugh epugh deleted the test_if_predefined_tags_work_with_empty_database_schema branch January 10, 2022 16:13
DonGroovy1120 added a commit to DonGroovy1120/ecorous that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predefined Tags File doesn't work with order of Evolutions
2 participants