Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic auth username case insensitive #144

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Basic auth username case insensitive #144

merged 6 commits into from
Feb 22, 2024

Conversation

Paul-Blanchaert
Copy link
Contributor

Validation of user name in basic auth module should be case insensitive

epugh
epugh reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To merge this however can you bump the build version?

epugh
epugh suggested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump build version and then i'll merge ;-)

epugh
epugh approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epugh epugh merged commit c341912 into querqy:master Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epugh epugh epugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paul-Blanchaert @epugh