-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the plugin to OpenSearch 2.0 and Querqy-Lucene 5.4 #18
Conversation
"querqy.opensearch.RewriterShardContextsTest.testClearRewritersFromCache -> Seems to be flaky" - I'm seeing the same under ES. It seems that in some cases, the test frame work does not go through the process of creating the Let me push my branch to querqy-elasticsearch, maybe this will show a solution for some of the other issues. |
I converted this into a draft PR so that we don't merge it accidentally |
I finally found a fix for the flaky RewriterShardsContextsTest in the query-elasticsearch version: https://github.com/querqy/querqy-elasticsearch/pull/23/files#diff-3d9c183f14569b387180b9b3b4c237991c4ff47113d3f345fe5d41bacc2af7b0 The problem is that the test framework seems to re-use the QuerqyQueryBuilder object in case the request goes to the 'local node' instead of fully processing a request and creating a new QuerqyQueryBuilder object. In that case, the QuerqyPlugin is not invoked and cannot inject a QuerqyProcessor object, which leads to an NPE. As the nodes are picked randomly by the test framework, the test doesn't always fail. |
@renekrie Sure I'll take this up, sorry for the delay. Missed the above comment. |
Signed-off-by: Shenoy Pratik <[email protected]>
… with 5.4 changes Signed-off-by: Shenoy Pratik <[email protected]>
…tPut, TransportDelete Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Ported changes for RewriterShardsContext and WordbreakRewriter. All tests pass for the local build |
Signed-off-by: Shenoy Pratik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ps48
Upgrades include:
NOTE: I see 3 test failures, @JohannesDaniel @renekrie might need some help with these.
- querqy.opensearch.RewriterShardContextsTest.testClearRewritersFromCache -> Seems to be flaky- querqy.opensearch.rewriter.WordBreakCompoundRewriterFactoryTest.testCreateRewriter -> Maybe related to #11- querqy.opensearch.rewriter.WordBreakCompoundRewriterFactoryTest.testThatDefaultConfigurationIsApplied -> Maybe related to upstream querqy changesIssues resolved: #16, #15