quota: Fix join on caching repo size (PROJQUAY-3889) (#1381)

Method for calculating size of repo joined on repo id instead of manifest id. This causes deleted manifests to be counted. Change updates call to join on manifest id.

Co-authored-by: bcaton <[email protected]>

data/model/repository.py

@@ -733,16 +733,17 @@ def force_cache_repo_size(repo_id: int):
     try:
         now_ms = get_epoch_timestamp_ms()
         subquery = (
-            Tag.select(Tag.repository_id)
+            Tag.select(Tag.manifest)
             .where(Tag.hidden == False)
             .where((Tag.lifetime_end_ms >> None) | (Tag.lifetime_end_ms > now_ms))
-            .group_by(Tag.repository_id)
+            .where(Tag.repository_id == repo_id)
+            .group_by(Tag.manifest)
             .having(fn.Count(Tag.name) > 0)
         )
 
         cache = (
             Manifest.select(fn.Sum(Manifest.layers_compressed_size).alias("size_bytes"))
-            .join(subquery, on=(subquery.c.repository_id == Manifest.repository_id))
+            .join(subquery, on=(subquery.c.manifest_id == Manifest.id))
             .where(Manifest.repository == repo_id)
         ).scalar()