Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding verify false to mirror check (PROJQUAY-8577) #1017

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

bcaton85
Copy link
Collaborator

@bcaton85 bcaton85 commented Feb 14, 2025

The init check in the mirror container previously did not verify TLS, nor does it need to. It just needs to ensure that Quay is responding. When we switched to python TLS was still being verified. We disable this and allow redirects which only checks the connection.

@bcaton85 bcaton85 changed the title Adding verify false to mirror check adding verify false to mirror check (PROJQUAY_8577) Feb 14, 2025
@bcaton85 bcaton85 changed the title adding verify false to mirror check (PROJQUAY_8577) adding verify false to mirror check (PROJQUAY-8577) Feb 14, 2025
@bcaton85 bcaton85 merged commit d84a9bf into quay:master Feb 14, 2025
9 of 14 checks passed
@bcaton85
Copy link
Collaborator Author

/cherry-pick redhat-3.13

@openshift-cherrypick-robot

@bcaton85: new pull request created: #1018

In response to this:

/cherry-pick redhat-3.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bcaton85
Copy link
Collaborator Author

/cherry-pick redhat-3.12

@openshift-cherrypick-robot

@bcaton85: #1017 failed to apply on top of branch "redhat-3.12":

Applying: adding verify false to mirror check
Using index info to reconstruct a base tree...
M	kustomize/components/mirror/mirror.deployment.yaml
Falling back to patching base and 3-way merge...
Auto-merging kustomize/components/mirror/mirror.deployment.yaml
CONFLICT (content): Merge conflict in kustomize/components/mirror/mirror.deployment.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 adding verify false to mirror check

In response to this:

/cherry-pick redhat-3.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bcaton85
Copy link
Collaborator Author

/cherry-pick redhat-3.12

@bcaton85
Copy link
Collaborator Author

/cherry-pick redhat-3.11

@bcaton85
Copy link
Collaborator Author

/cherry-pick redhat-3.10

@bcaton85
Copy link
Collaborator Author

/cherry-pick redhat-3.9

@openshift-cherrypick-robot

@bcaton85: new pull request created: #1024

In response to this:

/cherry-pick redhat-3.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@bcaton85: new pull request created: #1025

In response to this:

/cherry-pick redhat-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@bcaton85: #1017 failed to apply on top of branch "redhat-3.9":

Applying: adding verify false to mirror check
Using index info to reconstruct a base tree...
M	kustomize/components/mirror/mirror.deployment.yaml
Falling back to patching base and 3-way merge...
Auto-merging kustomize/components/mirror/mirror.deployment.yaml
CONFLICT (content): Merge conflict in kustomize/components/mirror/mirror.deployment.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 adding verify false to mirror check

In response to this:

/cherry-pick redhat-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@bcaton85: new pull request created: #1026

In response to this:

/cherry-pick redhat-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bcaton85
Copy link
Collaborator Author

/cherry-pick redhat-3.9

@openshift-cherrypick-robot

@bcaton85: new pull request created: #1027

In response to this:

/cherry-pick redhat-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants