Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-template-library: add support for GitHub Actions #364

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Nov 8, 2024

Unfortunately tedious to test... I suggest merging if you don't see obvious mistakes and fixing problems if any afterwards. Can be validated by removing TRAVIS variable definitions done as part of quattor/template-library-examples#40.

@jouvin jouvin requested a review from jrha November 8, 2024 12:12
@jouvin
Copy link
Contributor Author

jouvin commented Nov 8, 2024

@jrha I am not sure to understand the codeclimate error... May be my eyes are tired!

@jouvin jouvin force-pushed the gtl_github_action_support branch from 503dd25 to 4648e56 Compare November 8, 2024 14:28
jrha
jrha previously approved these changes Nov 8, 2024
Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrha jrha added this to the 24.10 milestone Nov 8, 2024
@jouvin jouvin force-pushed the gtl_github_action_support branch 2 times, most recently from 53cbed8 to c205488 Compare November 8, 2024 15:19
@jouvin
Copy link
Contributor Author

jouvin commented Nov 8, 2024

Should hopefully be ok now.

@jouvin jouvin force-pushed the gtl_github_action_support branch from c205488 to 0a7c033 Compare November 8, 2024 15:27
@jrha jrha merged commit aac3947 into quattor:master Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants