Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce url.scheme tag into http.server.active.requests metric #46553

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Introduce url.scheme tag into http.server.active.requests metric #46553

merged 1 commit into from
Feb 28, 2025
+5 −2

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 28, 2025 •
edited
Loading

@quarkus-bot quarkus-bot

This comment was marked as resolved.

Sign in to view
@geoand geoand requested a review from brunobat February 28, 2025 06:41
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2025

/cc @brunobat (micrometer), @ebullient (micrometer)

@geoand
Copy link
Contributor Author

geoand commented Feb 28, 2025

I assume we want this in the upcoming LTS, right?

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 323a5db.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@brunobat
Copy link
Contributor

Yes, we should backport

@brunobat brunobat merged commit bc14c86 into quarkusio:main Feb 28, 2025
35 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 28, 2025
@geoand geoand deleted the #46539 branch February 28, 2025 09:50
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.2 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@brunobat brunobat brunobat approved these changes

Assignees
No one assigned
Labels
area/metrics kind/bugfix
Projects
None yet
Milestone
3.19.2
Development

Successfully merging this pull request may close these issues.

This Gauge has been already registered "http.server.active.requests"
4 participants
@geoand @brunobat @cescoffier @gsmet