Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default S2I native binary image from UBI8 to UBI9 #46338

Merged

Conversation

michalvavrik
Copy link
Member

I raised this in PR description here #46231 but we never got to discuss it, I think even S2I native binary image must be UBI9-based because all of other images are based on UBI9.

@michalvavrik michalvavrik force-pushed the feature/use-ubi9-binary-s2i-img-by-default branch from 93e09c4 to 000b284 Compare February 18, 2025 14:24
Copy link

quarkus-bot bot commented Feb 18, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 000b284.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed(MicrometerTimedInterceptorTest.java:150)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)

@gsmet gsmet merged commit 71ab441 into quarkusio:main Feb 18, 2025
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 18, 2025
@michalvavrik michalvavrik deleted the feature/use-ubi9-binary-s2i-img-by-default branch February 18, 2025 20:34
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.0 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants