Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mongodb-client to use @ConfigMapping #46070

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Feb 4, 2025

Part of #45446

This comment has been minimized.

This comment has been minimized.

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Feb 4, 2025

ccompile error

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Feb 4, 2025

🎊 PR Preview d656dc3 has been successfully built and deployed to https://quarkus-pr-main-46070-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but I noticed a small issue.

Could you adjust and squash the commits?

Thanks!

Comment on lines 54 to 55
@WithConverter(TrimmedStringConverter.class)
Optional<String> credentialsProvider();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want Optional<@WithConverter(TrimmedStringConverter.class) String> and same for the other occurrences.

@mcruzdev mcruzdev force-pushed the config-mongodb-client branch 2 times, most recently from cd197a9 to 5bff774 Compare February 4, 2025 19:55
@quarkus-bot quarkus-bot bot added area/openapi area/platform Issues related to definition and interaction with Quarkus Platform area/smallrye area/swagger-ui labels Feb 4, 2025
@mcruzdev mcruzdev force-pushed the config-mongodb-client branch from 2715f2b to a08b744 Compare February 4, 2025 20:05
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 4, 2025

This comment has been minimized.

This comment has been minimized.

@mcruzdev mcruzdev force-pushed the config-mongodb-client branch from a08b744 to 84cfa31 Compare February 4, 2025 20:39
@gsmet
Copy link
Member

gsmet commented Feb 4, 2025

Sorry we collided :).

This comment has been minimized.

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Feb 4, 2025

I will finalize things.

@gsmet gsmet force-pushed the config-mongodb-client branch from 5aa470f to a620f6a Compare February 4, 2025 21:35
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be all good now and I rebased to get the CI fix.

Copy link

quarkus-bot bot commented Feb 4, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit a620f6a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Feb 4, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a620f6a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 28d1816 into quarkusio:main Feb 4, 2025
24 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 4, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 4, 2025
@tms0
Copy link

tms0 commented Feb 5, 2025

Hi @mcruzdev, @gsmet,

I am the maintainer of the quarkus-mongock extension. I just noticed that this change breaks the build of the extension : https://github.com/quarkiverse/quarkus-mongock/actions/runs/13150659666/job/36704570744

I wonder how can I take this change into account in a backward-compatible way?

Thanks,
Valentin

@gsmet
Copy link
Member

gsmet commented Feb 5, 2025

@tms0 hey. We will communicate much larger about this soon. Roberto sent an email yesterday on quarkus-dev and I was going to have a look at the Ecosystem CI failures today.

Unfortunately, this is a bit of a big bang change. We know it's not ideal but we really need to move to this new infrastructure.

We could have the option of restoring just enough old config (I think you just need the database name) for a couple of months but we will drop the old infrastructure at some point anyway so I'm not sure it's worth it. I checked if there could be other alternatives but I don't see anything that could provide you with the database name.

I don't know if your extension evolves a lot, do you think you could move main to use 3.19 when we release 3.19.0 and create a branch for older releases? Or would it be too uncomfortable?

Thanks for reaching out :).

@gsmet
Copy link
Member

gsmet commented Feb 5, 2025

@tms0 that being said, you could use an approach similar to what @gastaldi did here: https://github.com/quarkiverse/quarkus-ironjacamar/pull/158/files#diff-546c20e149ef134f4ad79befb3f960d9ef06f1945aea77fdfd92fdd9cf845880R128-R130 .

Ideally you would get back to using proper config mapping in the future but it could ease the transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants