-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Create procedure for Deploying Quarkus applications compiled to native executables based #45986
base: main
Are you sure you want to change the base?
Docs: Create procedure for Deploying Quarkus applications compiled to native executables based #45986
Conversation
This comment has been minimized.
This comment has been minimized.
7160234
to
66970a6
Compare
This comment has been minimized.
This comment has been minimized.
🎊 PR Preview 2786932 has been successfully built and deployed to https://quarkus-pr-main-45986-preview.surge.sh/version/main/guides/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sheila - Excellent work. I've offered some minor suggestions to improve consistency and clarity. Feel free to adopt or leave as you like.
docs/src/main/asciidoc/deploying-to-openshift-native-howto.adoc
Outdated
Show resolved
Hide resolved
quarkus.native.container-build=true | ||
---- | ||
. Optional: Set the following properties in the `application.properties` file, as required by your environment: | ||
.. If you are using an untrusted certificate, configure the `KubernetesClient` property: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. If you are using an untrusted certificate, configure the `KubernetesClient` property: | |
.. Trust untrusted certificates: |
---- | ||
quarkus.kubernetes-client.trust-certs=true | ||
---- | ||
.. Expose the service to create an {openshift} route: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. Expose the service to create an {openshift} route: | |
.. Enable access to your application from outside the cluster by exposing an {openshift} route: |
+ | ||
[source,properties] | ||
---- | ||
quarkus.openshift.jvm-dockerfile=src/main/docker/Dockerfile.custom-native |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this example show jvm-dockerfile
instead of native-dockerfile
? Is native-dockerfile
a placeholder and jvm-dockerfile
an actual value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Think this should be quarkus.openshift.native-dockerfile=src/main/docker/Dockerfile.custom-native. @iocanel, can you please confirm this?
docs/src/main/asciidoc/deploying-to-openshift-native-howto.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/deploying-to-openshift-native-howto.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/deploying-to-openshift-native-howto.adoc
Outdated
Show resolved
Hide resolved
oc get svc <3> | ||
---- | ||
<1> List the image streams created. | ||
<2> View a list of pods associated with your current OpenShift project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<2> View a list of pods associated with your current OpenShift project. | |
<2> List the running pods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to "List the pods associated with your current OpenShift project."
docs/src/main/asciidoc/deploying-to-openshift-native-howto.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/deploying-to-openshift-native-howto.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: shjones <[email protected]>
Signed-off-by: shjones <[email protected]>
Signed-off-by: shjones <[email protected]>
66970a6
to
c64a8b9
Compare
Status for workflow
|
Based on the Red Hat build of Quarkus guide Deploying on OpenShift Container Platform guide, this PR creates the Deploying Quarkus applications compiled to native executables procedure.
See QDOCS-1083