Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Create procedure for Deploying Quarkus applications compiled to native executables based #45986

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sheilamjones
Copy link
Contributor

Based on the Red Hat build of Quarkus guide Deploying on OpenShift Container Platform guide, this PR creates the Deploying Quarkus applications compiled to native executables procedure.

See QDOCS-1083

@sheilamjones sheilamjones changed the title Docs: Create deploying Quarkus applications compiled to native executables procedure Docs: Create procedure for Deploying Quarkus applications compiled to native executables based Jan 30, 2025

This comment has been minimized.

@sheilamjones sheilamjones force-pushed the QDOCS-1083-native-executables branch from 7160234 to 66970a6 Compare February 6, 2025 10:50

This comment has been minimized.

Copy link

github-actions bot commented Feb 6, 2025

🎊 PR Preview 2786932 has been successfully built and deployed to https://quarkus-pr-main-45986-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sheila - Excellent work. I've offered some minor suggestions to improve consistency and clarity. Feel free to adopt or leave as you like.

quarkus.native.container-build=true
----
. Optional: Set the following properties in the `application.properties` file, as required by your environment:
.. If you are using an untrusted certificate, configure the `KubernetesClient` property:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. If you are using an untrusted certificate, configure the `KubernetesClient` property:
.. Trust untrusted certificates:

----
quarkus.kubernetes-client.trust-certs=true
----
.. Expose the service to create an {openshift} route:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. Expose the service to create an {openshift} route:
.. Enable access to your application from outside the cluster by exposing an {openshift} route:

+
[source,properties]
----
quarkus.openshift.jvm-dockerfile=src/main/docker/Dockerfile.custom-native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this example show jvm-dockerfile instead of native-dockerfile? Is native-dockerfile a placeholder and jvm-dockerfile an actual value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Think this should be quarkus.openshift.native-dockerfile=src/main/docker/Dockerfile.custom-native. @iocanel, can you please confirm this?

oc get svc <3>
----
<1> List the image streams created.
<2> View a list of pods associated with your current OpenShift project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<2> View a list of pods associated with your current OpenShift project.
<2> List the running pods.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to "List the pods associated with your current OpenShift project."

@sheilamjones sheilamjones force-pushed the QDOCS-1083-native-executables branch from 66970a6 to c64a8b9 Compare February 8, 2025 00:12
Copy link

quarkus-bot bot commented Feb 8, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c64a8b9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants