Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the Grafana LGTM dashboards - part 2 #45747

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

alesj
Copy link
Contributor

@alesj alesj commented Jan 21, 2025

These 3 items from this issue: #43599

  • Increase the scraper frequency

  • In devmode, increase default output rate so data shows quicker on the dashboards

  • Only activate the scraper if the Prometheus registry is present.

@alesj alesj requested a review from brunobat January 21, 2025 12:34

This comment has been minimized.

Copy link

github-actions bot commented Jan 21, 2025

🎊 PR Preview 392dbf0 has been successfully built and deployed to https://quarkus-pr-main-45747-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@alesj alesj force-pushed the dash_1 branch 2 times, most recently from d620c8b to b50701a Compare January 22, 2025 09:30

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@brunobat brunobat changed the title Improvements to the Grafana LGTM dashboards Improvements to the Grafana LGTM dashboards - part 2 Jan 24, 2025
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alesj, when I only have the opentelemetry extension, I continue to see the scraper calling /q/metrics.
That call must only be active it the micrometer prometheus registry is a dependency of the project,

This comment has been minimized.

@brunobat
Copy link
Contributor

I think the machine is so resource constrained that the scraper hasn't started to work by the end of the test.
The only way to make sure is to get logs from the scraper.

This comment has been minimized.

@brunobat
Copy link
Contributor

I think you deleted my test tweaks when you push forced, @alesj

@alesj
Copy link
Contributor Author

alesj commented Jan 31, 2025 via email

This comment has been minimized.

@alesj
Copy link
Contributor Author

alesj commented Feb 1, 2025

I think the machine is so resource constrained that the scraper hasn't started to work by the end of the test. The only way to make sure is to get logs from the scraper.

How can it be so resource constrained?
Or how come the scraper doesn't start if the Prometheus says it started ... Prometheus is up and running

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

quarkus-bot bot commented Feb 4, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit dd2b104.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Feb 4, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit dd2b104.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@brunobat
Copy link
Contributor

brunobat commented Feb 5, 2025

The test is disabled. @alesj will create an issue to fix it on the CI.
It works on local machines and we really need this asap.
Do not backport.
CC @gsmet

@brunobat brunobat merged commit f886e7b into quarkusio:main Feb 5, 2025
54 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 5, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants