Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete config on re-used LGTM containers #45689

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Fix incomplete config on re-used LGTM containers #45689

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86538a6
Fix word choice in comment because somehow in English the verb of ded…
holly-cummins Jan 17, 2025
8450e15
Consolidate logic on two config paths to solve problem of missing con…
holly-cummins Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix word choice in comment because somehow in English the verb of ded… 
…uction is deduce, not deduct.
  • Loading branch information
@holly-cummins
holly-cummins committed Jan 17, 2025
commit 86538a6911dfe8ef560fbc78d2f8f8e7e5c9f587
4 changes: 2 additions & 2 deletions ...ommon/src/main/java/io/quarkus/observability/devresource/DevResourceLifecycleManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ default Container<T> container(T config, ModulesConfiguration root) {
}

/**
* Deduct current config from params.
* If port are too dynamic / configured, it's hard to deduct,
* Deduce current config from params.
* If port are too dynamic / configured, it's hard to deduce,
* since configuration is not part of the devservice state.
* e.g. different ports then usual - Grafana UI is 3000, if you do not use 3000,
* it's hard or impossible to know which port belongs to certain property.
Expand Down