Use Stork 2.2.1 fixing an issue about k8s SD refreshing cache #34731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
approved these changes
Jul 13, 2023
|
The test failures seems suspicious |
looking at it |
|
It's weird, I don't see any Stork tests failing, can you point me to the good link? |
|
There are a lot of failures, but if you think they are not related, rebase onto main so we can get a new fresh CI run |
|
rebase onto main? or 3.2 branch? |
|
Hm... Why the PR done against |
Because it is a bug fix and @gsmet suggested do it this way |
|
Is this change already in |
Yes |
|
Understood, thanks. I'll rerun the tests in that case. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @cescoffier